Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Republish package under @stellar/ scope #714

Merged
merged 6 commits into from
Nov 21, 2023
Merged

Republish package under @stellar/ scope #714

merged 6 commits into from
Nov 21, 2023

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Nov 20, 2023

Notice that this is targeting the stable branch: we will only include this rename as part of the stable package release.

See stellar/js-xdr#111, stellar/js-xdr#112, and stellar/js-xdr#113 for what was needed in that package to accomplish this.

This also moves the code to use @stellar/js-xdr instead of js-xdr.

Related: stellar/js-stellar-sdk#851.

@Shaptic Shaptic added this to the Soroban Stable P20 Release milestone Nov 20, 2023
@Shaptic Shaptic self-assigned this Nov 20, 2023
@Shaptic Shaptic requested review from sreuland and a team November 20, 2023 21:50
Copy link

github-actions bot commented Nov 20, 2023

Size Change: -823 B (0%)

Total Size: 3.19 MB

Filename Size Change
dist/stellar-base.js 2.34 MB -108 B (0%)
dist/stellar-base.min.js 849 kB -715 B (0%)

compressed-size-action

Copy link

@stellarsaur stellarsaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the very minor GitHub Actions warnings

@Shaptic Shaptic merged commit 8d8b09b into stable Nov 21, 2023
4 checks passed
@Shaptic Shaptic deleted the rename-package branch November 21, 2023 17:49
Shaptic added a commit that referenced this pull request Dec 5, 2023
…#710)

* Upgrade XDR to the final, stable testnet version. (#704, #715)

XDR has been upgraded to the latest stable version. This is mostly renames, but
it includes the following relevant breaking changes:
  - `Operation.bumpFootprintExpiration` is now `extendFootprintTtl` and its
  `ledgersToExpire` field is now named `extendTo`, but it serves the same
  purpose. - `xdr.ContractExecutable.contractExecutableToken` is now
  `contractExecutableStellarAsset` - `xdr.SorobanTransactionData.refundableFee`
  is now `resourceFee` - In turn, `SorobanDataBuilder.setRefundableFee` is now
  `setResourceFee` - This new fee encompasses the entirety of the
  Soroban-related resource fees. Note that this is distinct from the
  "network-inclusion" fee that you would set on your transaction (i.e.
  `TransactionBuilder(..., { fee: ... })`). - In TypeScript, the
  `Operation.BumpFootprintExpiration` is now `Operation.ExtendFootprintTtl`

Commit: stellar/stellar-xdr @ bb54e50

* Add helpful abstractions for common invocation types. (#703)
* Drop incorrect key entry for contract footprint (#709)
* Republish package under @stellar/ scope (#714)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants